Skip to content

add bzlmod support#2670

Merged
zyearn merged 4 commits into
apache:masterfrom
oathdruid:switch-to-bzlmod
Jul 14, 2024
Merged

add bzlmod support#2670
zyearn merged 4 commits into
apache:masterfrom
oathdruid:switch-to-bzlmod

Conversation

@oathdruid

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: #2654

Problem Summary:

What is changed and the side effects?

Changed:
Switch bazel dependency from WORKSPACE to bzlmod style

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm

wwbmmm commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

LGTM

@wwbmmm

wwbmmm commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

@zyearn 有空也看看

@oathdruid

Copy link
Copy Markdown
Contributor Author

any suggestion?

@zyearn zyearn merged commit 9d23af8 into apache:master Jul 14, 2024
@oathdruid oathdruid deleted the switch-to-bzlmod branch July 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants